Fix concurrent access #2 #719
Open
+97
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juev
approved these changes
Feb 18, 2025
miklezzzz
force-pushed
the
fix-concurrent-map-access-2
branch
from
62233b3 to
5782d59
Compare
|
Why not use sync.Map victoriaMetrics blog? |
|
to play safe, I suppose.
|
ldmonster
approved these changes
Feb 19, 2025
juev
approved these changes
Feb 19, 2025
miklezzzz
force-pushed
the
fix-concurrent-map-access-2
branch
from
5657f1f to
493af2d
Compare
yalosev
reviewed
Feb 24, 2025
Comment on lines
+34
to
42
| // dependencies | ||
| scheduleManager schedulemanager.ScheduleManager | ||
|
|
||
| l sync.RWMutex | ||
| // All hooks with 'kubernetes' bindings | ||
| ScheduleLinks map[string]*ScheduleBindingToCrontabLink | ||
|
|
||
| // bindings configurations | ||
| ScheduleBindings []htypes.ScheduleConfig |
There was a problem hiding this comment.
Suggested change
| // dependencies | |
| scheduleManager schedulemanager.ScheduleManager | |
| l sync.RWMutex | |
| // All hooks with 'kubernetes' bindings | |
| ScheduleLinks map[string]*ScheduleBindingToCrontabLink | |
| // bindings configurations | |
| ScheduleBindings []htypes.ScheduleConfig | |
| // All hooks with 'kubernetes' bindings | |
| ScheduleLinks map[string]*ScheduleBindingToCrontabLink | |
| // bindings configurations | |
| ScheduleBindings []htypes.ScheduleConfig | |
| l sync.RWMutex | |
| // dependencies | |
| scheduleManager schedulemanager.ScheduleManager |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some other race conditions to fix have been detected.
Overview
What this PR does / why we need it
Special notes for your reviewer